[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] One more bugfix for xfs_lowbit64
On Fri, Aug 22, 2003 at 04:02:13PM -0500, Steve Lord wrote:
> On Fri, 2003-08-22 at 15:10, Andi Kleen wrote:
> > (mea culpa). The error return was broken too, it would return -2,
> > not -1 for errors. Makes no difference in the callers, they never check
> > for -1, but is still better to conform to the spec.
>
> Thanks Andi, this did have to happen one day after 1.3 didn't it.
;-)
I don't think it's very critical, From a quick look none of the
callers ever pass in anything more than 32bits.
It's used for the number of super block fields, which is < 32
and for some bmap, which seems to be limited to 21 bits by
the extractor function.
-Andi