Re: XFS and O_STREAMING

[Nathan Scott <nathans@sgi.com>]

On Mon, Dec 09, 2002 at 02:49:17PM -0600, Steve Lord wrote:
> On Mon, 2002-12-09 at 14:45, Buzbee, James wrote:
> > Steve Lord wrote:
> > > 
> > > We do use generic_file_write, it is just buried underneath our own
> > > layer. O_STREAMING sounds like the old dropbehind stuff and should
> > > work just fine.
> > 
> > 
> > Hmmm... I'm trying it with 2.4.18 and xfs 1.1  For debugging, I put 
> > "printk's" at the top of generic_file_read and generic_file_write in 
> > linux/mm/filemap.c (the patched file) and I never see any output from 
> > the generic_file_write, just from the generic_file_read.
> 
> Ah, you mean back in ancient history we did not use it, we do in
> more recent code. To be honest I cannot remember what the code 
> might have been doing in 1.1 anymore.

We also use generic_file_write_nolock() directly, rather than using
generic_file_write (a thin wrapper around generic_file_write_nolock
with added i_sem locking), so a printk in generic_file_write is not
going to be tripped for an XFS filesystem.

cheers.

-- 
Nathan