Re: EA bug while convert from INLINE to EXTENT with XATTR_REPLACE

[Steve Lord <lord@sgi.com>]

On Sun, 2002-05-26 at 00:03, Tang Lingbo (Allan) wrote:
> Hi,
> 
> One of the attached files is used to hit the bug as following, the patch is
> my solution:
> 
> A. set a EA with 10 chars (name length + value length) 
> B. change above name's value with chars more than 32 
> 
> If we used the EA through lib, the operations seems OK because it
> has never used XATTR_REPLACE flag.
> 
> The patch will solve the problem.
> 
> Regards,
> Allan

The patch has problems I think:

The old code would remove the existing value of the attribute, it
would then calculate if the replacement attribute fitted in the
inode. The new code will only put the new attribute inside the inode
if both the old and the new attribute values - along with all other
attributes still fit in the inode.

Can you expand more on what you think is going wrong with the existing
code?

Steve

-- 

Steve Lord                                      voice: +1-651-683-3511
Principal Engineer, Filesystem Software         email: lord@sgi.com