[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: TAKE - cleanup a large array on the stack

On Thu, May 23, 2002 at 11:43:53AM -0500, Steve Lord wrote:
> Noticed by Sebastian Kun, this removes a 2K array from the
> stack and allocates the memory we actually need instead.
> 
> 
> Date:  Thu May 23 09:44:23 PDT 2002
> Workarea:  jen.americas.sgi.com:/src/lord/xfs-linux.2.4
> 
> The following file(s) were checked into:
>   bonnie.engr.sgi.com:/isms/slinx/2.4.x-xfs
> 
> 
> Modid:  2.4.x-xfs:slinx:120043a
> linux/fs/xfs/xfs_dir2_block.c - 1.23
> linux/fs/xfs/xfs_dir2_sf.c - 1.24

+	buf = kmem_alloc(old_isize, GFP_KERNEL);

doesn't look right, I think KM_SLEEP is what you wanted to add..