Re: xfs_repair trouble

[Ragnar Kjørstad <xfs@ragnark.vestdata.no>]

On Tue, May 07, 2002 at 04:03:42PM +0200, Willi Langenberger wrote:
> If "xlog_find_verify_log_record" returns -1, it jumps over the
> assignment "*blk_no = last_blk" and returns "error" (which, in this
> case is -1).  So we have the case that "xlog_find_zeroed" returns -1,
> in spite of the fact that *blk_no is _not_ set. But, according to the
> comment of the function:
> 
>  * Return:
>  *      0  => the log is completely written to
>  *      -1 => use *blk_no as the first block of the log
>  *      >0 => error has occurred
>  */

Yes, xlog_find_verify_log_record return negative numbers for errors (at
least in some cases), and xlog_find_zeroed is supposed to return
possitive numbers for errors, but passes on the value from
xlog_find_verify_log_record. Clearly something fishy is going on :)



-- 
Ragnar Kjørstad
Big Storage