Re: TAKE - quota patch

[Nathan Scott <nathans@sgi.com>]

hi Shawn,

On Wed, Feb 20, 2002 at 03:36:13PM -0500, Shawn Starr wrote:
> <ShawnXFSWerk> asmlinkage long sys_quotactl(int cmd, const char
> *special, int
>                id, caddr_t addr)
> <ShawnXFSWerk> asmlinkage long sys_quotactl(int cmd, const char
> *special,
>                qid_t id, __kernel_caddr_t addr)
> 
> 
> redefinition of qid_t in quota.h /fs.h
> 
> These two system calls are conflicting and are different.
> 
> quota.c and dquot.c contain sys_quotactl functions. 
> 
> this is with 2.4.18-rc2 + 2.4.18-pre3-ac-quota patch + 2.4.18-rc2-ac1 +
> XFS + rmap12f.
> 

OK, is this the order you applied the patches?  If so, this is
probably the problem (the order).

The order should instead be:
2.4.18-rc2 + 2.4.18-rc2-ac1 + 2.4.18-pre3-ac2-quotactl + XFS + rmap12f.
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

(ie. the patch I put in CVS must be applied to the new quota from -ac,
and not to the old quota from base)

Let me know where that gets you.  I'm not sure about the redefinition
of qid_t issue, but perhaps that will resolve itself by correcting the
patch order.

cheers.

-- 
Nathan