Re: xfsrestore dumps core on cumulative restore with -B (dirattr.c:945)

[ivanr@sgi.com]

On Sat, 2 Feb 2002, Bernhard R. Erdmann wrote:

> I discovered a bug in xfsrestore 1.1.14 - it dumps core when the last
> level of a cumlative dump is restored using the option "-B" to set mode
> on . of the dumped filesystem.

I couldn't reproduce the problem here, but judging by your core file, the
following patch should avoid the core dump.  I shall have a chat to Tim
(the xfsrestore expert) next week, and see if we can get a better solution.


--- /usr/tmp/TmpDir.13642-0/cmd/xfsdump/restore/tree.c_1.12     Fri Feb  8 13:10:00 2002
+++ cmd/xfsdump/restore/tree.c  Fri Feb  8 10:56:56 2002
@@ -2461,6 +2461,9 @@
        struct fsxattr fsxattr;         /* can we get rid of this? */
        intgen_t rval;

+       if ( dah == DAH_NULL )
+               return;
+
        fsxattr.fsx_xflags = dirattr_get_xflags( dah );
        fsxattr.fsx_extsize = dirattr_get_extsize( dah );




Ivan

-- 
Ivan Rayner
ivanr@sgi.com