Re: XFS/setfacl ordering bug still? - I think I Fixed ---- I think :) - "patch" included

[Nathan Scott <nathans@sgi.com>]

hi,

On Sat, Aug 25, 2001 at 10:08:28PM -0700, Eric Peters wrote:
> After doing some gdb work and crap and downloading hte original setfacl port
> from http://acl.bestbits.at I noticed the acl_check function wasn't allowing
> more than one ACL_USER entry so:
> 
> libacl.c line 73:
>                 case ACL_USER:
>                         if (state != ACL_USER)
>                                 FAIL_CHECK (ACL_MISS_ERROR);
>                         if (ace->ae_id < qual || ace->ae_id ==
> ACL_UNDEFINED_ID)
>                                 FAIL_CHECK (ACL_DUPLICATE_ERROR);
>                         qual = ace->ae_id + 1;

> should become:
>                 case ACL_USER:
>                         if (state != ACL_USER)
>                                 FAIL_CHECK (ACL_MISS_ERROR);
>                         if (ace->ae_id < qual || ace->ae_id ==
> ACL_UNDEFINED_ID)
>                                 FAIL_CHECK (ACL_DUPLICATE_ERROR);
>                         qual = ace->ae_id + 1;
>                         needs_mask = 1;
>                         break;
> 

yup, thats clearly a bug.  fixed, thanks.

cheers.

-- 
Nathan