RE: [NFS] kernel nfsd crash

["Christian, Chip" <chip.christian@storageapps.com>]

And of course it was 
	return pdentry;
not 
	return();
I typed that into the email by hand...


-----Original Message-----
From: Stephen Walton [mailto:swalton@sunspot.csun.edu]
Sent: Thursday, August 09, 2001 17:49
To: Christian, Chip
Cc: 'NFS list (E-mail)'; Linux XFS (E-mail)
Subject: RE: [NFS] kernel nfsd crash


On Thu, 9 Aug 2001, Christian, Chip wrote:

>     --- nfsfh.c 2001/05/09 00:54:56 1.1
>     +++ nfsfh.c 2001/05/09 00:56:01
>     @@ -244,6 +244,10 @@
>               */
>              pdentry = child->d_inode->i_op->lookup(child->d_inode, tdentry);
>              d_drop(tdentry); /* we never want ".." hashed */
>     + if (!pdentry && tdentry->d_inode == NULL) {
>     + dput(tdentry);
>     + pdentry = ERR_PTR(-EINVAL);
> ==> + return()
>     + }

Wouldn't this be simpler:

	if (!pdentry && tdentry->d_inode == NULL) {
		dput(tdentry);
		return ERRPTR(-EINVAL);
	}

----
Stephen Walton, Professor of Physics and Astronomy,
California State University, Northridge
stephen.walton@csun.edu