netdev
[Top] [All Lists]

Re: [PATCH] forcedeth: fix random memory scribbling bug

To: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] forcedeth: fix random memory scribbling bug
From: Linus Torvalds <torvalds@xxxxxxxx>
Date: Sat, 24 Dec 2005 11:57:48 -0800 (PST)
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, Ayaz Abdulla <AAbdulla@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Netdev <netdev@xxxxxxxxxxx>
In-reply-to: <43AD726A.5010703@xxxxxxxxxxxxxxxx>
References: <43AD4ADC.8050004@xxxxxxxxxxxxxxxx> <43AD64AB.2070306@xxxxxxxxx> <43AD726A.5010703@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx

On Sat, 24 Dec 2005, Manfred Spraul wrote:
> 
> > 2) I have requested multiple times that you avoid MIME...
> 
> It's the first time that you complain about Content-Transfer-Encoding: 7bit
> attachments.

These proper text encodings are easy to _apply_, because the raw email is 
uncorrupted. 

However, attachments are still broken for a very fundamental reason: 
basically no email client will ever quote them on replies. Which means 
that if somebody has commentary about some specific part of the patch, the 
attachement is _totally_ the wrong thing to do.

In other words, there's a reason I encourage people VERY STRONGLY to use 
in-line patches. If you have a broken mailer that corrupts whitespace, 
please just fix it.

                Linus

<Prev in Thread] Current Thread [Next in Thread>