RE: [PATCH 2/2] forcedeth: scatter gather and segmentation offload support

["Ayaz Abdulla" <AAbdulla@xxxxxxxxxx>]

Thanks.

I will resend version 45 (bug fix) and 46 (irq modes) since they will
need new modifications based on the changes made in this patch and the
comments you suggested.


-----Original Message-----
From: Jeff Garzik [mailto:jgarzik@xxxxxxxxx] 
Sent: Tuesday, October 25, 2005 9:53 PM
To: Ayaz Abdulla
Cc: Stephen Hemminger; Manfred Spraul; Netdev
Subject: Re: [PATCH 2/2] forcedeth: scatter gather and segmentation
offload support


Ayaz Abdulla wrote:
> Yes, forgot that indent.
> 
> Here it is again with that fix.

I applied this version of the patch to the 'upstream' patch.

In the future, as Stephen noted, it would really be preferred that you 
split up the patch into logical changes.  patch 1/2 netdev_priv(), patch

2/2 SG support, for example.

Also, always include the Signed-off-by line, even on patch resends.  See
        http://linux.yyz.us/patch-format.html
for more info.

        Jeff