| To: | Nishanth Aravamudan <nacc@xxxxxxxxxx> |
|---|---|
| Subject: | Re: ipvs_syncmaster brings cpu to 100% |
| From: | Julian Anastasov <ja@xxxxxx> |
| Date: | Thu, 29 Sep 2005 10:00:12 +0300 (EEST) |
| Cc: | Luca Maranzano <liuk001@xxxxxxxxx>, Dave Miller <davem@xxxxxxxxxxxxx>, Wensong Zhang <wensong@xxxxxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050928132639.GA5791@xxxxxxxxxx> |
| References: | <68559cef05092207022f1f0df4@xxxxxxxxxxxxxx> <498263350509230815eb08a73@xxxxxxxxxxxxxx> <20050926032807.GI18357@xxxxxxxxxxxx> <20050926043400.GD5079@xxxxxxxxxx> <20050926080508.GF11027@xxxxxxxxxxxx> <20050926081229.GA23755@xxxxxxxxxxxx> <20050926131104.GA7532@xxxxxxxxxx> <68559cef05092606521cc13f9a@xxxxxxxxxxxxxx> <20050926142109.GD7532@xxxxxxxxxx> <20050928022307.GK18765@xxxxxxxxxxxx> <20050928132639.GA5791@xxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Hello,
On Wed, 28 Sep 2005, Nishanth Aravamudan wrote:
> Yes, the information in that thread is the same as what Luca said. It's
> a load average problem, not a CPU utilisation problem (those threads are
> sleeping!) If Luca could test the msleep_interruptible() version of the
> patch and it works (like I said, performance should not change, but the
> load average will drop to by 2), then I will ACK the patch for mainline
> acceptance.
Agreed. It seems your initial conversion was based on wrong
assumptions, quoting you:
> Description: Use ssleep() instead of schedule_timeout() to guarantee the task
> delays as expected. The first two replacements use TASK_INTERRUPTIBLE but do
> not
> check for signals, so ssleep() should be appropriate.
As all signals are blocked from daemonize and even explicitly
later it was not necessary to convert to non-interruptible variant.
Regards
--
Julian Anastasov <ja@xxxxxx>
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RFC][PATCH] identify in_dev_get rcu read-side critical sections, Herbert Xu |
|---|---|
| Next by Date: | Re: rwlock recursion on CPU#0, netfilter related?, Harald Welte |
| Previous by Thread: | Re: ipvs_syncmaster brings cpu to 100%, Nishanth Aravamudan |
| Next by Thread: | Re: ipvs_syncmaster brings cpu to 100%, Luca Maranzano |
| Indexes: | [Date] [Thread] [Top] [All Lists] |