| To: | "'netdev@xxxxxxxxxxx'" <netdev@xxxxxxxxxxx> |
|---|---|
| Subject: | Netdevice reference counting issues in net/core/dv.c |
| From: | Ben Greear <greearb@xxxxxxxxxxxxxxx> |
| Date: | Sat, 27 Aug 2005 23:42:54 -0700 |
| Organization: | Candela Technologies |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.10) Gecko/20050719 Fedora/1.7.10-1.3.1 |
dv.c has several issues. First, it uses the check_args method to find the device. It acquires a hold on the device and then drops it in the same method. Upon return from this check_args method, code then continues to use the reference to the device. This could lead to access-after-free errors. Also, check_args has an arbitrary device-index check to make sure it is less that 1000. This is bogus since we can have many more devices than that... If there is a maintainer that wants to fix this, please be my guest. Otherwise, I'll make a stab at fixing it as part of my ref-count debugging work. Thanks, Ben -- Ben Greear <greearb@xxxxxxxxxxxxxxx> Candela Technologies Inc http://www.candelatech.com |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Leaked net-device reference in eql.c, Arnaldo Carvalho de Melo |
|---|---|
| Next by Date: | Re: [PATCH 3/3] Cleanup direct calls into IP stack, Jacques Chion |
| Previous by Thread: | Leaked net-device reference in eql.c, Ben Greear |
| Next by Thread: | hu64 - Trade Global Currency - jx23, Jocelyn Cannon |
| Indexes: | [Date] [Thread] [Top] [All Lists] |