netdev
[Top] [All Lists]

OK if tg3_get_eeprom_hw_cfg() reads SRAM?

To: davem@xxxxxxxxxxxxx, mchan@xxxxxxxxxxxxxxxxxxxxxxx
Subject: OK if tg3_get_eeprom_hw_cfg() reads SRAM?
From: Grant Grundler <iod00d@xxxxxx>
Date: Wed, 17 Aug 2005 23:34:52 -0700
Cc: netdev@xxxxxxxxxxx, Grant Grundler <iod00d@xxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.9i
Michael,
tg3_get_eeprom_hw_cfg() was added in this patch:
        
http://www.kernel.org/git/?p=linux/kernel/git/davem/net-2.6.git;a=commit;h=7d0c41ef89dad9008edf1c3c0022721ebad39999

The comment before tg3_get_eeprom_hw_cfg() suggests tg3 should
ONLY be touching PCI cfg space until the NIC gets to D0 power state.
But tg3_get_eeprom_hw_cfg() is called before tg3_set_power_state(tp,0).

Is it OK for tg3_get_eeprom_hw_cfg() to read NIC_SRAM_DATA_CFG?

thanks,
grant

<Prev in Thread] Current Thread [Next in Thread>