netdev
[Top] [All Lists]

Re: [PATCH] Add prefetches in net/ipv4/route.c

To: dada1@xxxxxxxxxxxxx
Subject: Re: [PATCH] Add prefetches in net/ipv4/route.c
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Mon, 01 Aug 2005 11:39:16 -0400 (EDT)
Cc: davem@xxxxxxxxxxxxx, rick.jones2@xxxxxx, netdev@xxxxxxxxxxx, Robert.Olsson@xxxxxxxxxxx
In-reply-to: <42EDDA50.4010405@xxxxxxxxxxxxx>
References: <42EA7491.1010207@xxxxxx> <20050730.205209.112313042.davem@xxxxxxxxxxxxx> <42EDDA50.4010405@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
From: Eric Dumazet <dada1@xxxxxxxxxxxxx>
Date: Mon, 01 Aug 2005 10:16:16 +0200

> Last time I checked, read_mostly had a meaning only if CONFIG_X86 ||
> CONFIG_SPARC64

Meaning that other platforms need to implement this,
big deal :)

I do agree that the implementor of __read_mostly should
have just let the build break instead so folks could
simply be forced to fix things up.

It's actually a trivial change, and the author therefore
could also have updated all the platform's vmlinux.lds.S files
instead of ifdef'ing this stuff.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] Add prefetches in net/ipv4/route.c, David S. Miller <=