| To: | Manfred Spraul <manfred@xxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] forcedeth: Additional ethtool support |
| From: | Jeff Garzik <jgarzik@xxxxxxxxx> |
| Date: | Sun, 31 Jul 2005 00:51:04 -0400 |
| Cc: | Francois Romieu <romieu@xxxxxxxxxxxxx>, Netdev <netdev@xxxxxxxxxxx>, renaud.lienhart@xxxxxxx |
| In-reply-to: | <42D16656.6000207@xxxxxxxxxxxxxxxx> |
| References: | <42D101EC.6000608@xxxxxxxxxxxxxxxx> <20050710172833.GA1951@xxxxxxxxxxxxxxxxxxxxxxxxxx> <42D16656.6000207@xxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla Thunderbird 1.0.6-1.1.fc4 (X11/20050720) |
Manfred Spraul wrote: Not for a nic without complete documentation: What if an arch uses 64-bit reads to read two registers at the same time? Not all nics like that, for example IIRC natsemi explicitely mandates 32-bit reads. x86-64 doesn't, it uses 32-bit reads, but I don't like the idea of using memcpy to read registers.I agree with your other remarks, updated patch attached. Going through my pending folder, I was about to apply all the queued forcedeth patches. However, in two cases, you violated Rule #6 of
http://linux.yyz.us/patch-format.html
Please resend ALL forcedeth patches, with proper descriptions, so I
don't have to hunt through previous patch versions, and previous emails,
to match up the correct description to the correct patch.
Jeff
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Add prefetches in net/ipv4/route.c, David S. Miller |
|---|---|
| Next by Date: | Re: [PATCH 2.6.12.1 1/12] S2io: Code cleanup, Jeff Garzik |
| Previous by Thread: | Re: [PATCH] forcedeth: Additional ethtool support, Francois Romieu |
| Next by Thread: | Re: [PATCH] forcedeth: Additional ethtool support, David Hollis |
| Indexes: | [Date] [Thread] [Top] [All Lists] |