| To: | Wade Farnsworth <wfarnsworth@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] emac: add bamboo support |
| From: | Eugene Surovegin <ebs@xxxxxxxxxxx> |
| Date: | Thu, 28 Jul 2005 10:31:09 -0700 |
| Cc: | Matt Porter <mporter@xxxxxxxxxxxxxxxxxxx>, jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <1122571506.22059.146.camel@xxxxxxxxxxxxxxxxxxx> |
| Mail-followup-to: | Wade Farnsworth <wfarnsworth@xxxxxxxxxx>, Matt Porter <mporter@xxxxxxxxxxxxxxxxxxx>, jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx |
| References: | <20050727104247.C1114@xxxxxxx> <20050728065943.GA16041@xxxxxxxxxxxxxxxx> <1122571506.22059.146.camel@xxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.5.1i |
On Thu, Jul 28, 2005 at 10:25:07AM -0700, Wade Farnsworth wrote: > If you know of a better way of doing this please let me know. Yes, I do and IIRC told you last time. Make it generic - move all board specific stuff where it belongs - board support files. Add additional field(s) to ocp_func_emac_data which will allow EMAC driver to override PHY modes, the same way we specify PHY id now, for example. With this approach, we won't have to add another board specific crap to the driver next time hw vendor fuck ups their hw. -- Eugene |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] emac: add bamboo support, Wade Farnsworth |
|---|---|
| Next by Date: | Re: [PATCH] Add prefetches in net/ipv4/route.c, David S. Miller |
| Previous by Thread: | Re: [PATCH] emac: add bamboo support, Wade Farnsworth |
| Indexes: | [Date] [Thread] [Top] [All Lists] |