netdev
[Top] [All Lists]

Re: [PATCH] loop unrolling in net/sched/sch_generic.c

To: Eric Dumazet <dada1@xxxxxxxxxxxxx>
Subject: Re: [PATCH] loop unrolling in net/sched/sch_generic.c
From: Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx>
Date: Fri, 8 Jul 2005 08:08:54 -0300
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, tgraf@xxxxxxx, netdev@xxxxxxxxxxx
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:references; b=pvOtFjpFVGDjCkTLOeTyT/IvAFfxMYvxjIezp3v0K58pi2eEEUe2XNsFR0s7gFmCaxpUpVaVpE2Fwl1f4imeK1B36pl7jdBdMeDFSOs0v9NLWpWztQ4SaQBhFr84JQhshkgNE42VhgcFcusXL5UFPWyorx6RVwMvpTAaY0EHPOY=
In-reply-to: <42CE3722.3070208@xxxxxxxxxxxxx>
References: <20050706124206.GW16076@xxxxxxxxxxxxxx> <20050707.141718.85410359.davem@xxxxxxxxxxxxx> <42CE22CE.7030902@xxxxxxxxxxxxx> <20050708.003014.125896217.davem@xxxxxxxxxxxxx> <42CE3722.3070208@xxxxxxxxxxxxx>
Reply-to: Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx


On 7/8/05, Eric Dumazet <dada1@xxxxxxxxxxxxx> wrote:
David S. Miller a écrit :
> From: Eric Dumazet <dada1@xxxxxxxxxxxxx>
> Date: Fri, 08 Jul 2005 08:53:02 +0200
>
>
>>About making sk_buff smaller, I use this patch to declare 'struct
>>sec_path *sp' only ifdef CONFIG_XFRM, what do you think ?  I also
>>use a patch to declare nfcache, nfctinfo and nfct only if
>>CONFIG_NETFILTER_CONNTRACK or CONFIG_NETFILTER_CONNTRACK_MODULE are
>>defined, but thats more intrusive.  Also, tc_index is not used if
>>CONFIG_NET_SCHED only is declared but none of CONFIG_NET_SCH_* In my
>>case, I am using CONFIG_NET_SCHED only to be able to do : tc -s -d
>>qdisc
>
>
> Distributions enable all of the ifdefs, and that is thus the
> size and resultant performance most users see.

Well, I had this idea because I found another similar use in include/linux/ip.h

struct inet_sock {
     /* sk and pinet6 has to be the first two members of inet_sock */
     struct sock     sk;
#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
     struct ipv6_pinfo   *pinet6;
#endif


/me pleads guilty, Dave, any problem with removing this #ifdef? Humm, I'll think about using
the skb_alloc_extension() idea for struct sock, but this pinet6 sucker is a bit more difficult I guess...

- Arnaldo

<Prev in Thread] Current Thread [Next in Thread>