| To: | Zhu Yi <yi.zhu@xxxxxxxxx> |
|---|---|
| Subject: | Re: ipw2100: more cleanups |
| From: | Pavel Machek <pavel@xxxxxxx> |
| Date: | Mon, 4 Jul 2005 09:05:06 +0200 |
| Cc: | jketreno@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, jbohac@xxxxxxx, jbenc@xxxxxxx |
| In-reply-to: | <1120456146.27821.85.camel@xxxxxxxxxxxxxxxxxxx> |
| References: | <20050513214025.GA1863@xxxxxxxxxx> <1120456146.27821.85.camel@xxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.9i |
Hi!
> > More cleanups (relative to ipw2100-1.1.0 version). Highlights include
> > removing of two printk wrappers.
>
> [snip]
>
> > -static DEVICE_ATTR(bssinfo, S_IRUGO, show_bssinfo, NULL);
>
> Any special reason to remove these driver sysfs entries?
Umm, yes, they should not be needed and we do not want to maintain
them in /sys forever. /sys should be "one value per file", and
definitely not for debugging stuff like this. (See debugfs)
Anyway I think I did drop that patch from newer cleanup attempts.
Pavel
--
teflon -- maybe it is a trademark, but it should not be.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: ipw2100: more cleanups, Zhu Yi |
|---|---|
| Next by Date: | Re: [TG3]: About hw coalescing infrastructure., Eric Dumazet |
| Previous by Thread: | Re: ipw2100: more cleanups, Zhu Yi |
| Next by Thread: | Re: [TG3]: About hw coalescing infrastructure., Eric Dumazet |
| Indexes: | [Date] [Thread] [Top] [All Lists] |