netdev
[Top] [All Lists]

Re: [PATCH]: Tigon3 new NAPI locking v2

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [PATCH]: Tigon3 new NAPI locking v2
From: Greg Banks <gnb@xxxxxxxxxxxxxxxxx>
Date: Tue, 07 Jun 2005 20:11:12 +1000
Cc: Linux Network Development list <netdev@xxxxxxxxxxx>, mchan@xxxxxxxxxxxx
In-reply-to: <20050603.122558.88474819.davem@xxxxxxxxxxxxx>
Organization: Silicon Graphics Inc, Australian Software Group.
References: <20050603.122558.88474819.davem@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 2005-06-04 at 05:25, David S. Miller wrote:
> This version incorporates two bug fixes from Michael.
> 
> 1) Check the mailbox register for 0x1 while polling on the COMPLETE
>    state bit.
> 
> 2) Remove the BUG_ON() check in tg3_restart_ints(), it can legally and
>    harmlessly occur.
> 
> Point #2 may want some refinements, but this patch below is good
> enough for testing.

This patch seems to run well, so far without the lockup we saw
with the first version.  It really helps with irq fairness when
we have lots of tg3 and Fibre Channel HBA interrupts going to the
same CPU.

Greg.
-- 
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.



<Prev in Thread] Current Thread [Next in Thread>