Re: RFC: NAPI packet weighting patch

[Jon Mason <jdmason@xxxxxxxxxx>]

On Friday 03 June 2005 03:31 pm, David S. Miller wrote:
> From: jamal <hadi@xxxxxxxxxx>
> Date: Fri, 03 Jun 2005 15:59:31 -0400
>
> > But one that you could validate by putting proper hooks. As an example,
> > try to restore a descriptor every time you pick one - for an example of
> > this look at the sb1250 driver.
>
> Yes, this in my mind is exactly the problem.  TG3 does this
> properly, as do several other drivers.
>
> You should never defer RX buffer replenishment, you should
> always do it as you grab packets off of the ring.  You will
> starve the chip otherwise.

e1000 isn't the only driver to do things this way.  r8169, via-velocity, dl2k, 
and skge (and I'm sure many more).  Might be nice to perform a driver audit 
to see what drivers do this.