netdev
[Top] [All Lists]

Re: [PATCH] ieee80211: Update generic definitions to latest specs.

To: <gwingerde@xxxxxxx>
Subject: Re: [PATCH] ieee80211: Update generic definitions to latest specs.
From: Jiri Benc <jbenc@xxxxxxx>
Date: Fri, 3 Jun 2005 11:33:43 +0200
Cc: <netdev@xxxxxxxxxxx>, <jbohac@xxxxxxx>
In-reply-to: <20050602190232.340996282D7@xxxxxxxxxxxx>
References: <20050602190232.340996282D7@xxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 2 Jun 2005 21:02:24 +0200, gwingerde@xxxxxxx wrote:
> I was thinking about that too, but couldn't find a proper shorter
> version without losing the descriptive meaning.
> 
> Do you have any suggestions to shorten them?

Maybe we can lose a bit of descriptiveness and put comments above
definitions instead?

I can imagine names such as WLAN_STATUS_ASSOC_DENIED_NOSPECTRUM,
WLAN_STATUS_ASSOC_DENIED_BAD_POWER,
WLAN_STATUS_ASSOC_DENIED_BAD_SUPPCHANNS, WLAN_REASON_DISASSOC_BAD_POWER,
and so on. Also WLAN_STATUS_ASSOC_DENIED_NOSHORT seems to be acceptable
for me.

More often used identifiers probably could have even shorter name - what
about renaming IEEE80211_FCTL_PROTECTEDFRAME to
IEEE80211_FCTL_PROTECTED?

Thanks,

-- 
Jiri Benc
SUSE Labs

<Prev in Thread] Current Thread [Next in Thread>