netdev
[Top] [All Lists]

Re: RFC: NAPI packet weighting patch

To: john.ronciak@xxxxxxxxx
Subject: Re: RFC: NAPI packet weighting patch
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 02 Jun 2005 17:18:12 -0700 (PDT)
Cc: jdmason@xxxxxxxxxx, shemminger@xxxxxxxx, hadi@xxxxxxxxxx, mitch.a.williams@xxxxxxxxx, netdev@xxxxxxxxxxx, Robert.Olsson@xxxxxxxxxxx, ganesh.venkatesan@xxxxxxxxx, jesse.brandeburg@xxxxxxxxx
In-reply-to: <468F3FDA28AA87429AD807992E22D07E0450BFDB@orsmsx408>
References: <468F3FDA28AA87429AD807992E22D07E0450BFDB@orsmsx408>
Sender: netdev-bounce@xxxxxxxxxxx
From: "Ronciak, John" <john.ronciak@xxxxxxxxx>
Date: Thu, 2 Jun 2005 17:11:20 -0700

> I like this idea as well but I do an issue with it.  How would this
> stack code find out that the weight is too high and pacekts are being
> dropped (not being polled fast enough)?  It would have to check the
> controller stats to see the error count increasing for some period.  I'm
> not sure this is workable unless we have some sort of feedback which the
> driver could send up (or set) saying that this is happening and the
> dynamic weight code could take into acount.

What more do you need other than checking the statistics counter?  The
drop statistics (the ones we care about) are incremented in real time
by the ->poll() code, so it's not like we have to trigger some
asynchronous event to get a current version of the number.

<Prev in Thread] Current Thread [Next in Thread>