netdev
[Top] [All Lists]

Re: ipv4 ipsec

To: edgar.iglesias@xxxxxxxx
Subject: Re: ipv4 ipsec
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Tue, 31 May 2005 15:56:42 -0700 (PDT)
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20050531224717.GE4068@xxxxxxxxxxxxxxxxx>
References: <20050531224717.GE4068@xxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
From: Edgar E Iglesias <edgar.iglesias@xxxxxxxx>
Date: Wed, 1 Jun 2005 00:47:17 +0200

> Im not sure this is the correct list for ipsec issues, but shouldn't
> the size check at the bottom of net/ipv4/esp4.c be the other way
> around (2.6.11)?

You are right, good catch.  Luckily the size of esp_decap_data
is exactly 20 bytes, so the incorrect test happens to be harmless.

> --- /usr/src/linux-2.6.11-gentoo-r8/net/ipv4/esp4.c     2005-05-11 
> 10:05:03.000000000 +0200
> +++ esp4.c      2005-06-01 00:38:55.000000000 +0200

Please porperly -p1 root your patch so I can apply it, and also
please provide a "Signed-off-by: " line for yourself as well.

It may seem pointless for a one-line patch, but I want to get you
and others into the habit of submitting patches properly in the
future.

<Prev in Thread] Current Thread [Next in Thread>