| To: | jamal <hadi@xxxxxxxxxx> |
|---|---|
| Subject: | Re: RFC: NAPI packet weighting patch |
| From: | Mitch Williams <mitch.a.williams@xxxxxxxxx> |
| Date: | Tue, 31 May 2005 10:35:26 -0700 |
| Cc: | Stephen Hemminger <shemminger@xxxxxxxx>, "Williams, Mitch A" <mitch.a.williams@xxxxxxxxx>, netdev@xxxxxxxxxxx, Robert.Olsson@xxxxxxxxxxx, "Ronciak, John" <john.ronciak@xxxxxxxxx>, "Venkatesan, Ganesh" <ganesh.venkatesan@xxxxxxxxx>, "Brandeburg, Jesse" <jesse.brandeburg@xxxxxxxxx> |
| In-reply-to: | <1117241786.6251.7.camel@xxxxxxxxxxxxxxxxxxxxx> |
| References: | <Pine.CYG.4.58.0505261406210.2364@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20050527085055.79da3d75@xxxxxxxxxxxxxxxxx> <Pine.CYG.4.58.0505271305590.2148@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20050527140132.1435132d@xxxxxxxxxxxxxxxxx> <1117241786.6251.7.camel@xxxxxxxxxxxxxxxxxxxxx> |
| Replyto: | "Mitch Williams" <mitch.a.williams@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Fri, 27 May 2005, jamal wrote: > > On Fri, 2005-27-05 at 14:01 -0700, Stephen Hemminger wrote: > > > > > Why not just allow adjusting dev->weight via sysfs? > > I think that should be good enough - and i thought your patch already > did this. > Adding a shift to the weight in a _weighted_ RR algorithm does sound > odd. > Stephen's patch only affects the weight for the backlog device. Exporting dev-> weight to sysfs will allow the weight to be set for any network device. Which makes perfect sense. I'll work on getting this done and verifying performance this week. Expect a patch in a few days. Thanks, guys. -Mitch |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] use mmiowb in tg3_poll, Jesse Barnes |
|---|---|
| Next by Date: | Re: RFC: NAPI packet weighting patch, Stephen Hemminger |
| Previous by Thread: | Re: RFC: NAPI packet weighting patch, jamal |
| Next by Thread: | Re: RFC: NAPI packet weighting patch, Stephen Hemminger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |