netdev
[Top] [All Lists]

Re: [PATCH 4/5] [NET] Add skb_find_text() to search for a text pattern i

To: Pablo Neira <pablo@xxxxxxxxxxx>
Subject: Re: [PATCH 4/5] [NET] Add skb_find_text() to search for a text pattern in skbs
From: Thomas Graf <tgraf@xxxxxxx>
Date: Sat, 28 May 2005 13:32:45 +0200
Cc: netdev@xxxxxxxxxxx, Jamal Hadi Salim <hadi@xxxxxxxxxx>
In-reply-to: <4297E172.5020907@xxxxxxxxxxx>
References: <20050527224725.GG15391@xxxxxxxxxxxxxx> <20050527224858.GK15391@xxxxxxxxxxxxxx> <4297E172.5020907@xxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
* Pablo Neira <4297E172.5020907@xxxxxxxxxxx> 2005-05-28 05:11
> Still miss something here. You aren't looking for matches in skbs 
> inserted in skb_shinfo(skb)->frag_list. Have a look at rusty's skb_iter 
> functions. Since he cooked those for this purpose (string matching), why 
> don't we use them instead of yours ?

Absolutely, I'm planning to use rusty's skb_iter instead. I postponed
this to when the core infrastructure is stable but thanks a lot for
this comment.

<Prev in Thread] Current Thread [Next in Thread>