| To: | shemminger@xxxxxxxx |
|---|---|
| Subject: | Re: [PATCH] (6/6) bridge: receive path optimization |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Thu, 26 May 2005 14:46:38 -0700 (PDT) |
| Cc: | bridge@xxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050526110425.27590eb8@xxxxxxxxxxxxxxxxx> |
| References: | <20050526110425.27590eb8@xxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
From: Stephen Hemminger <shemminger@xxxxxxxx> Date: Thu, 26 May 2005 11:04:25 -0700 > This improves the bridge local receive path by avoiding going > through another softirq. The bridge receive path is already being called > from a netif_receive_skb() there is no point in going through another > receiveq round trip. > > Recursion is limited because bridge can never be a port of a bridge > so handle_bridge() always returns. I applied all 6 patches, but this one in particular I'd like to comment on. Remember all of those bridge netfilter stack usage issues we have a few months ago? This could edge us back into those problems again. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2.6] fix deadlock with ip_queue and tcp local input path, Herbert Xu |
|---|---|
| Next by Date: | Re: primary and secondary ip addresses, David S. Miller |
| Previous by Thread: | RFC: NAPI packet weighting patch, Mitch Williams |
| Next by Thread: | Re: [Bridge] Re: [PATCH] (6/6) bridge: receive path optimization, Stephen Hemminger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |