netdev
[Top] [All Lists]

Re: [PATCH 2.6] fix deadlock with ip_queue and tcp local input path

To: laforge@xxxxxxxxxxxxx (Harald Welte)
Subject: Re: [PATCH 2.6] fix deadlock with ip_queue and tcp local input path
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 27 May 2005 07:38:57 +1000
Cc: netfilter-devel@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, jmorris@xxxxxxxxxx
In-reply-to: <20050526142420.GD13114@xxxxxxxxxxxxxxxxxxxxxxx>
Organization: Core
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686))
Harald Welte <laforge@xxxxxxxxxxxxx> wrote:
> 
> The patch below adds an additional queue for ip_queue verdicts.  They
> come up from userspace, are appended to a queue which is then processed
> by a tasklet.  The tasklet itself runs in softirq context, so when timer
> hardirq leaves, no tcp_delack_timer() will be executed until
> nf_reinject() has finished.

This seems to be overly complicated if all you want is to do this in
softirq context.  What's wrong with simply alling local_bh_disable?
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>