| To: | Michael Chan <mchan@xxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/6] bnx2: Fix excessive stack usage |
| From: | Jeff Garzik <jgarzik@xxxxxxxxx> |
| Date: | Tue, 24 May 2005 01:43:18 -0400 |
| Cc: | davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <1116908956.5984.4.camel@rh4> |
| References: | <1116892439.4908.1.camel@rh4> <1116894307.4908.28.camel@rh4> <429286A3.1060606@xxxxxxxxx> <1116908956.5984.4.camel@rh4> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050328 Fedora/1.7.6-1.2.5 |
Michael Chan wrote: On Mon, 2005-05-23 at 21:42 -0400, Jeff Garzik wrote:memleak -- you need to free good_mbuf.Oops, here is the revised patch with kfree(). Thanks. Fix excessive stack usage in bnx2_alloc_bad_rbuf() by replacing local variable array with kmalloc array. Also changed function to return error code, and changed some of the callers to check for the return code. Spotted by Jeff Garzik. Signed-off-by: Michael Chan <mchan@xxxxxxxxxxxx> ACK |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/6] bnx2: Fix excessive stack usage, Michael Chan |
|---|---|
| Next by Date: | Re: [git patches] 2.6.x net driver updates, Linus Torvalds |
| Previous by Thread: | Re: [PATCH 1/6] bnx2: Fix excessive stack usage, Michael Chan |
| Next by Thread: | Re: [PATCH 1/6] bnx2: Fix excessive stack usage, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |