netdev
[Top] [All Lists]

Re: [BUG 2.6.12-rc4] IPv6 xfrm tunnel oops with large packets

To: Christophe Saout <christophe@xxxxxxxx>
Subject: Re: [BUG 2.6.12-rc4] IPv6 xfrm tunnel oops with large packets
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 22 May 2005 05:49:32 +1000
Cc: linux-net@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, YOSHIFUJI Hideaki <yoshfuji@xxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <1116702611.14509.10.camel@xxxxxxxxxxxxxxxxxx>
References: <1116702611.14509.10.camel@xxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Sat, May 21, 2005 at 07:10:11PM +0000, Christophe Saout wrote:
> 
> The oops occurs in line 391 in net/ipv6/icmp.c:
> 
> >        idev = in6_dev_get(skb->dev);

Here is a minimal fix.

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

I wonder why I've never seen it before.

BTW, icmpv6_send seems to ignore its dev argument altogether.
Any reason why we can't just use it instead of skb->dev?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>