netdev
[Top] [All Lists]

Re: [PATCH] [BRIDGE] Set features based on slave's ones (was Ethernet Br

To: "Catalin(ux aka Dino) BOIE" <util@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH] [BRIDGE] Set features based on slave's ones (was Ethernet Bridging: Enable Hardware Checksumming)
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Thu, 19 May 2005 13:39:59 -0700
Cc: netdev@xxxxxxxxxxx, davem@xxxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.62.0505191654400.24043@xxxxxxxxxxxxxxxxxxx>
Organization: Open Source Development Lab
References: <Pine.LNX.4.62.0505191654400.24043@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 19 May 2005 18:28:26 +0300 (EEST)
"Catalin(ux aka Dino) BOIE" <util@xxxxxxxxxxxxxxx> wrote:

> Hello!
> 
> The attached patch, makes the bridge to select features (almost all) only 
> if _all_ devices supports them.
> The patch was tested (create a bridge, add an interface, remove the 
> interface and always check features flags).
> 
> What do you think?
> 
> Signed-off-by: Catalin(ux aka Dino) BOIE <catab at umbrella.ro>

Okay, but just open code this, don't need BR_FEAT_MASK
and br_features_change.

<Prev in Thread] Current Thread [Next in Thread>