Re: patch tulip-natsemi-dp83840a-phy-fix.patch added to -mm tree

[Jeff Garzik <jgarzik@xxxxxxxxx>]

akpm@xxxxxxxx wrote:
> +
> +                                       /* flush posted writes */
> +                                       ioread32(ioaddr + CSR15);
> +
> +                                       /* Sect 3.10.3 in DP83840A.pdf (p39) */
> +                                       udelay(500);
> +
> +                                       /* Section 4.2 in DP83840A.pdf (p43) */
> +                                       /* and IEEE 802.3 "22.2.4.1.1 Reset" */
> +                                       while (timeout-- &&
> +                                               (tulip_mdio_read (dev, phy_num, 
> MII_BMCR) & BMCR_RESET))
> +                                               udelay(100);

Note that while the patch creates the correct behavior, the delays above 
occur inside spin_lock_irqsave() and/or timer context.
I have been to get HP to fix this patch's delay problem for -years-.

        Jeff