Re: [PATCH] reduce stack usage for arlan

netdev

Re: [PATCH] reduce stack usage for arlan

To:	Jörn Engel <joern@xxxxxxxxxxxxxxxxxxxx>
Subject:	Re: [PATCH] reduce stack usage for arlan
From:	Jeff Garzik <jgarzik@xxxxxxxxx>
Date:	Sun, 15 May 2005 23:22:35 -0400
Cc:	netdev@xxxxxxxxxxx
In-reply-to:	<20050308153457.GB8703@xxxxxxxxxxxxxxxxxxxx>
References:	<20050308153457.GB8703@xxxxxxxxxxxxxxxxxxxx>
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050328 Fedora/1.7.6-1.2.5

Jörn Engel wrote:

Jean Tourrilhes indicated that this driver is currently unmaintained.
Jeff, do you want this patch?

 #define SARLSTR(var,nn) {\
-       char tmpStr[400];\
+       char tmpStr[50];\
        int  tmpLn = nn;\
-       if (nn > 399 ) tmpLn = 399; \
+       BUG_ON(tmpLn > 49);\

I'm uncomfortable with arbitrarily lowering the string size, even if itdoes include a BUG_ON()...


        Jeff

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH] reduce stack usage for arlan, Jeff Garzik <= Re: [PATCH] reduce stack usage for arlan, Jörn Engel

Previous by Date:	Re: [PATCH][RESENT] Generic HDLC update, Jeff Garzik
Next by Date:	Re: patch tulip-natsemi-dp83840a-phy-fix.patch added to -mm tree, Jeff Garzik
Previous by Thread:	Re: [PATCH][RESENT] Generic HDLC update, Jeff Garzik
Next by Thread:	Re: [PATCH] reduce stack usage for arlan, Jörn Engel
Indexes:	[Date] [Thread] [Top] [All Lists]