| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: issue with new TCP TSO stuff |
| From: | Andi Kleen <ak@xxxxxx> |
| Date: | 12 May 2005 22:26:29 +0200 |
| Date: | Thu, 12 May 2005 22:26:29 +0200 |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <20050512.130341.82102354.davem@xxxxxxxxxxxxx> |
| References: | <m1sm0sttvy.fsf@xxxxxx> <20050512.122657.50069962.davem@xxxxxxxxxxxxx> <20050512200251.GA72662@xxxxxx> <20050512.130341.82102354.davem@xxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.1i |
On Thu, May 12, 2005 at 01:03:41PM -0700, David S. Miller wrote: > From: Andi Kleen <ak@xxxxxx> > Subject: Re: issue with new TCP TSO stuff > Date: 12 May 2005 22:02:51 +0200,Thu, 12 May 2005 22:02:51 +0200 > > > Sure, but did you verify it was the actual problem? (e.g. with a profiler) > > If the cache line the atomic operation is done on is EXCLUSIVE to the > > CPU then it should not take *that* long to do the atomic operations. > > Such issues cannot be measured like that, they tend to make > other operations slower by inducing cache misses elsewhere. Atomic operations, especially with cache misses, normally show in a fine grained profile. They also don't cause additional cache misses over non atomic writes. > I used my brain to analyze this slowdown, instead of the > computer, I'm sorry if that disturbs you :-) What disturbs me is your conclusion :) -Andi |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: issue with new TCP TSO stuff, David S. Miller |
|---|---|
| Next by Date: | Re: Sis900 and VLAN 8021q.o incompatible/MTU troubles, Francois Romieu |
| Previous by Thread: | Re: issue with new TCP TSO stuff, David S. Miller |
| Next by Thread: | Re: issue with new TCP TSO stuff, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |