netdev
[Top] [All Lists]

[PATCH 2/4] iseries_veth: Set dev->trans_start so watchdog timer works r

To: Andrew Morton <akpm@xxxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: [PATCH 2/4] iseries_veth: Set dev->trans_start so watchdog timer works right
From: Michael Ellerman <michael@xxxxxxxxxxxxxx>
Date: Thu, 12 May 2005 17:53:18 +1000
Cc: netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
Reply-to: michael@xxxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.8
Hi Andrew, Jeff,

The iseries_veth driver doesn't set dev->trans_start in it's TX path. This
will cause the net device watchdog timer to fire earlier than we want it to,
which causes the driver to needlessly reset its connections to other LPARs.

Signed-off-by: Michael Ellerman <michael@xxxxxxxxxxxxxx>
--

 iseries_veth.c |    2 ++
 1 files changed, 2 insertions(+)

Index: veth-fixes/drivers/net/iseries_veth.c
===================================================================
--- veth-fixes.orig/drivers/net/iseries_veth.c
+++ veth-fixes/drivers/net/iseries_veth.c
@@ -1023,6 +1023,8 @@ static int veth_start_xmit(struct sk_buf
 
        lpmask = veth_transmit_to_many(skb, lpmask, dev);
 
+       dev->trans_start = jiffies;
+
        if (! lpmask) {
                dev_kfree_skb(skb);
        } else {

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 2/4] iseries_veth: Set dev->trans_start so watchdog timer works right, Michael Ellerman <=