netdev
[Top] [All Lists]

Re: [2.6 patch] drivers/net/ixgb/: possible cleanups

To: Arjan van de Ven <arjan@xxxxxxxxxxxxx>
Subject: Re: [2.6 patch] drivers/net/ixgb/: possible cleanups
From: Adrian Bunk <bunk@xxxxxxxxx>
Date: Sat, 7 May 2005 14:38:17 +0200
Cc: Ganesh Venkatesan <ganesh.venkatesan@xxxxxxxxx>, ayyappan.veeraiyan@xxxxxxxxx, ganesh.venkatesan@xxxxxxxxx, john.ronciak@xxxxxxxxx, jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1115468645.6388.37.camel@xxxxxxxxxxxxxxxxxxxxx>
References: <20050506211834.GM3590@xxxxxxxxx> <5fc59ff3050506153523cd12dd@xxxxxxxxxxxxxx> <1115468645.6388.37.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Sat, May 07, 2005 at 02:24:04PM +0200, Arjan van de Ven wrote:
> On Fri, 2005-05-06 at 15:35 -0700, Ganesh Venkatesan wrote:
> > Adrian:
> > 
> > Some of your suggestions are already part of the driver we are
> > currently testing. This was based partly on your Feb '05 patch. We
> > will not be able to apply your patch as is since some of the changes
> > are in part of code that is shared with other drivers that are not
> > GPLd.
> 
> this sounds really bad.
> 
> Can you talk to the intel people in the ACPI group, they had a similar
> issue before but were able to resolve it by a proper dual license
> comment. It would be much preferable if people CAN do changes to the
> entire driver... what's the point of having it open source otherwise ;)

I'm not sure whether Ganesh was really talking about license issues, or 
whether the problem is that my patch #if 0's away code they use in other 
non-GPL'ed drivers.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


<Prev in Thread] Current Thread [Next in Thread>