Re: [7/7] [IPSEC] Add XFRMA_SA/XFRMA_POLICY for delete notification

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Sat, May 07, 2005 at 08:04:16AM -0400, jamal wrote:
> 
> This is incosistent in two ways:
> 1) Typical netlink behavior is to return the object being deleted.
> Every other netlink user behaves that way - the only exception is sone
> filters in tc and this is because they cant retrieve that detail
> (something that needs resolution at some point). There is nothing that
> xfrm_usersa_id provides that can be found in xfrm_usersa_info.
> Same for the policy.

This analogy is flawed since unlike other rtnetlink delete operations
the xfrm delete operations do not carry the same payload type as their
add/update cousins.

> 2) You cant have one behavior when something is deleted by pfkey and a
> different one when it is deleted by netlink.

As far as I can see the behaviour is identical.

> So i would recommend pulling this one out.

Well I don't really have time to get into another debate so I'll
chuck this one out.
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt