netdev
[Top] [All Lists]

Re: [NET]: Avoid useless iterating in netlink dump functions

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [NET]: Avoid useless iterating in netlink dump functions
From: jamal <hadi@xxxxxxxxxx>
Date: Sat, 07 May 2005 08:10:39 -0400
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Maillist netdev <netdev@xxxxxxxxxxx>
In-reply-to: <427BE147.9080508@xxxxxxxxx>
Organization: unknown
References: <427B8FC3.4000305@xxxxxxxxx> <1115413473.13922.38.camel@xxxxxxxxxxxxxxxxxxxxx> <427BDDD4.1000808@xxxxxxxxx> <1115414222.13922.41.camel@xxxxxxxxxxxxxxxxxxxxx> <427BE147.9080508@xxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 2005-06-05 at 23:27 +0200, Patrick McHardy wrote:
> jamal wrote:
> > On Fri, 2005-06-05 at 23:12 +0200, Patrick McHardy wrote:
> > 
> >>action dumping is on my list for more treatment than this :)
> > 
> > Well, that does sound scary ;-> What do you have in mind.
> > Recall, there are two paths to dumping actions - unlike any other thing
> > in the kernel.
> 
> Don't worry :) Its actually action walking that is on my list.
> What I have planed is roughly:
> - clean up and move hashing functions to act_common.c
> - put data needed for hashing (size, pointer to memory, ...) in
>   struct tc_act_common, which is referenced by struct tc_action_ops
> - add callback based walking function so we don't need two of them
>
> This should also get rid of all the large functions contained in
> headerfiles.
> 

Ah, ok ;->
Weve discussed this already - I think DaveM already took in the simple
action patch that i posted a while back; it doesnt seem like you will
collide with that - just double check.

cheers,
jamal


<Prev in Thread] Current Thread [Next in Thread>