netdev
[Top] [All Lists]

Re: resend patch: xfrm policybyid

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: resend patch: xfrm policybyid
From: jamal <hadi@xxxxxxxxxx>
Date: Thu, 05 May 2005 18:17:15 -0400
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev <netdev@xxxxxxxxxxx>
In-reply-to: <20050505213239.GA29526@xxxxxxxxxxxxxxxxxxx>
Organization: unknown
References: <1115298877.7680.75.camel@xxxxxxxxxxxxxxxxxxxxx> <20050505213239.GA29526@xxxxxxxxxxxxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 2005-06-05 at 07:32 +1000, Herbert Xu wrote:
                        
> > +   if (delp && excl) { 
> > +           ret = -EEXIST;
> > +           goto pol_err;
> > +   }
> > +
> > +   /* insert, sorted by prio*/
> >     write_lock_bh(&xfrm_policy_lock);
> 
> This is still racy since delp can be killed by timers before you get
> the lock.

Ok, Herbert - this is fixable: I take it moving the lock one up is
sufficient; i dont mind if you fix it and add it to your list.

BTW, are the event patches in Davems queue somewhere?
I have a few ipsec ones (cosmetic) that i will send later.

cheers,
jamal


<Prev in Thread] Current Thread [Next in Thread>