netdev
[Top] [All Lists]

Re: ip route del bug?

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: ip route del bug?
From: Jamal Hadi Salim <hadi@xxxxxxxx>
Date: Thu, 05 May 2005 15:15:24 -0400
Cc: Stephen Hemminger <shemminger@xxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <427A6B77.1030200@xxxxxxxxx>
Organization: ZNYX Networks
References: <427A3370.3090001@xxxxxxxxxxxxxx> <20050505113557.7d21baf2@xxxxxxxxxxxxxxxxx> <427A6B77.1030200@xxxxxxxxx>
Reply-to: hadi@xxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 2005-05-05 at 20:52 +0200, Patrick McHardy wrote:
> Stephen Hemminger wrote:
> > It looks like an accidental behaviour (of the kernel) in response to
> > an ip route delete netlink message with no additional data.
> 
> I don't believe it is accidental, it seems correct to me to delete
> the default route when no more specific selector is given. To avoid
> this, iproute could print an error when dst.bytelen == 0.

Agreed - basically the kernel does what its told.  
I think the check should be on missing dst (default will always give you
bytelen of 0 for example and is legit).
Patchlet attached.

cheers,
jamal

Attachment: iprdl_p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>