netdev
[Top] [All Lists]

Re: [PATCH] resource release cleanup in net/

To: Jesper Juhl <juhl-lkml@xxxxxx>
Subject: Re: [PATCH] resource release cleanup in net/
From: Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx>
Date: Sat, 30 Apr 2005 18:26:45 -0300
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Jouni Malinen <jkmaline@xxxxxxxxx>, James Morris <jmorris@xxxxxxxxxxxxxxxx>, Pedro Roque <roque@xxxxxxxxxxx>, Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, Kunihiro Ishiguro <kunihiro@xxxxxxxxxxxxxx>, Mitsuru KANDA <mk@xxxxxxxxxxxxxx>, lksctp-developers@xxxxxxxxxxxxxxxxxxxxx, Andy Adamson <andros@xxxxxxxxx>, Bruce Fields <bfields@xxxxxxxxx>, netdev@xxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=bjkSYR5kZEDxqeO6xmgmaW2/ky58mGuy8vAXr0FwulN77W1+tcBYdhP9qJYPfoR3Ncy+NA1PcJ2wo1thCS5SaSctX30RnIupPgkt6lMzONF22t6d3hvAxNGPPwP+911LnuBOd9g7e/mHN+rySryPtkCv39E/q9hfA1IKw85+azI=
In-reply-to: <Pine.LNX.4.62.0504302219520.2094@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <Pine.LNX.4.62.0504302219520.2094@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: acme@xxxxxxxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On 4/30/05, Jesper Juhl <juhl-lkml@xxxxxx> wrote:
> Hi David,
> 
> Since Andrew merged the patch that makes calling crypto_free_tfm() with a
> NULL pointer safe into 2.6.12-rc3-mm1, I made a patch to remove checks for
> NULL before calling that function, and while I was at it I removed similar
> redundant checks before calls to kfree() and vfree() in the same files.
> There are also a few tiny whitespace cleanups in there.

Jesper, I'd suggest that you left whitespaces for a separate patch, it
is always,
IMHO, better to have as small a patch as possible for reviewing.

- Arnaldo


<Prev in Thread] Current Thread [Next in Thread>