netdev
[Top] [All Lists]

Re: patch2: del/get byid

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: patch2: del/get byid
From: jamal <hadi@xxxxxxxxxx>
Date: Fri, 29 Apr 2005 21:08:12 -0400
Cc: Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <20050430004715.GA23429@xxxxxxxxxxxxxxxxxxx>
Organization: unknown
References: <20050428030325.GB23823@xxxxxxxxxxxxxxxxxxx> <1114658657.7663.110.camel@xxxxxxxxxxxxxxxxxxxxx> <1114698033.7663.197.camel@xxxxxxxxxxxxxxxxxxxxx> <20050428231154.GA14215@xxxxxxxxxxxxxxxxxxx> <1114779104.7800.22.camel@xxxxxxxxxxxxxxxxxxxxx> <1114816846.8929.6.camel@xxxxxxxxxxxxxxxxxxxxx> <20050429234952.GB22699@xxxxxxxxxxxxxxxxxxx> <1114819281.8929.9.camel@xxxxxxxxxxxxxxxxxxxxx> <20050430001248.GA22927@xxxxxxxxxxxxxxxxxxx> <1114821357.8929.27.camel@xxxxxxxxxxxxxxxxxxxxx> <20050430004715.GA23429@xxxxxxxxxxxxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 2005-30-04 at 10:47 +1000, Herbert Xu wrote:
> On Fri, Apr 29, 2005 at 08:35:57PM -0400, jamal wrote:
> >
> > > 1) You find delpol using xfrm_policy_byid/xfrm_policy_bysel.
> > 
> > Which increments the refcnt
> 
> Refcnt prevents the policy from being freed.  It doesn't prevent it
> from being deleted from the list.  Only the list lock can do that.
> 

Yes, of course. Look at the code carefuly,  the delpol is already
_unlinked_ when i call xfrm_policy_kill();-> 
If it wasnt so none of those tests would have worked; infact in my first
30 seconds of testing i discovered that when i listed after
an update;->

cheers,
jamal



<Prev in Thread] Current Thread [Next in Thread>