Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock

netdev

Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock

To:	alan@xxxxxxxxxxxxxxxxxxx (Alan Cox)
Subject:	Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock
From:	Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date:	Sat, 30 Apr 2005 11:02:48 +1000
Cc:	markb@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to:	<1114821473.24687.404.camel@xxxxxxxxxxxxxxxxxxxxx>
Organization:	Core
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686))

Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> On Iau, 2005-04-28 at 21:42, Mark Broadbent wrote:
>> The interrupt handling code in the tulip network driver appears to use a non 
>> IRQ safe spinlock in an interrupt context.  The following patch should 
>> correct 
>> this.
> 
> In what situations is this code path executed outside the IRQ handler ?

Only through poll_tulip via netpoll.  However, that is safe as well
since poll_tulip does a disable_irq(dev->irq).

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] Tulip interrupt uses non IRQ safe spinlock, Mark Broadbent Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock, Herbert Xu Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock, David S. Miller Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock, Sergey Vlasov Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock, Francois Romieu Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock, Herbert Xu Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock, Alan Cox Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock, Herbert Xu <=

Previous by Date:	Re: patch2: del/get byid, Herbert Xu
Next by Date:	Re: patch2: del/get byid, jamal
Previous by Thread:	Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock, Alan Cox
Next by Thread:	[PATCH] Add more explanation to tcp_prequeue comment, Andrew Grover
Indexes:	[Date] [Thread] [Top] [All Lists]