Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock

[Francois Romieu <romieu@xxxxxxxxxxxxx>]

kernel/irq/handle.c::__do_IRQ
[...]
        spin_lock(&desc->lock);
        desc->handler->ack(irq);
        /*
         * REPLAY is when Linux resends an IRQ that was dropped earlier
         * WAITING is used by probe to mark irqs that are being tested
         */
        action = NULL;
        if (likely(!(status & (IRQ_DISABLED | IRQ_INPROGRESS)))) {
                action = desc->action;
                status &= ~IRQ_PENDING; /* we commit to handling */
                status |= IRQ_INPROGRESS; /* we are handling it */
        }
        desc->status = status;

handle_IRQ_event(irq, regs, action) is issued a few lines below
if action != NULL

I thought this (strangely locked) code was supposed to disable reentrancy.

--
Ueimor