Re: Panic in sk_stream_wait_memory() while doing iSCSI testing

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

Badari Pulavarty <pbadari@xxxxxxxxxx> wrote:
> 
> I ran into panic in sk_stream_wait_memory() while doing iSCSI
> testing on 2.6.12-rc2. The problem seems to be while doing
> 
>        set_bit(SOCK_ASYNC_NOSPACE, &sk->sk_socket->flags);
> 
> sk->sk_socket seems to be NULL. Can this happen ? Do we need

If sk->sk_socket is NULL, then either the socket hasn't been
initialised yet or it has already been freed.  Either way you've
got socket life-cycle management issues in your code.

Basically, while you're in sk_stream_wait_memory, you must arrange
it so that the socket does not go away under you.  Normally this is
done by holding a reference on the socket, either directly or
indirectly through a file descriptor.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt