netdev
[Top] [All Lists]

Re: [KJ] [PATCH] Documentation/networking/dmfe.txt : Make documentation

To: kernel-janitors@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, jgarzik@xxxxxxxxx
Subject: Re: [KJ] [PATCH] Documentation/networking/dmfe.txt : Make documentation nicer
From: Ismail Donmez <ismail@xxxxxxxxxx>
Date: Wed, 27 Apr 2005 20:26:28 +0300
Cc: ismail@xxxxxxxxxx
In-reply-to: <20050427170703.GA3762@xxxxxxxxxxxxxxxxx>
Organization: Bogazici University
References: <200504262244.01258.ismail@xxxxxxxxxx> <20050427170703.GA3762@xxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.8.50
On Wednesday 27 April 2005 20:07, Domen Puncer wrote:
> On 26/04/05 22:44 +0300, Ismail Donmez wrote:
> > Hi,
> >
> > attached patch indents dmfe.txt to look like other docs. It adds a tip
> > about CNET cards using Davicom chipsets. Also it removes parts where it
> > refers to how to build driver out-of-kernel which seems to be cruft from
> > times where the driver was out of the kernel.
>
> Please, no quoted-printable, it makes it hard for scripts to parse right.
> (=20 and similar "characters")

Ok hopefully its ok now

>
> > Signed-off-by: ??smail Dönmez <ismail@xxxxxxxxxx>
>

Ok my unicode name is buggy ;)

> Uhh... I don't recall being discussed in which encoding this should be,
> ascii is a safe bet.
>
> > --- dmfe.txt        2004-07-24 09:45:13.000000000 +0300
> > +++ dmfe2.txt       2004-07-24 09:46:37.000000000 +0300
>
> Patch should be -p1 appliable... meaning these lines will be something
> like: --- linux-2.6.12-rc3/Documentation/dmfe.txt ...
> +++ linux-dev/Documentation/dmfe.txt ...
>
> > @@ -1,59 +1,65 @@
> > -  dmfe.c: Version 1.28        01/18/2000
> > +Davicom DM9102(A)/DM9132/DM9801 fast ethernet driver for Linux.
>
> Trailing whitespace.

Nice catch.

Here goes the new one :


Attached patch indents dmfe.txt to look like other docs. It adds a tip
about CNET cards using Davicom chipsets. Also it removes parts where it
refers to how to build driver out-of-kernel which seems to be cruft from
times where the driver was out of the kernel.

Signed-off-by: Ismail Dönmez <ismail@xxxxxxxxxx>

Attachment: dmfe.patch
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>