Re: [PATCH 2.6.12-rc2 3/3] tg3: Fix tg3_restart_ints()

["Michael Chan" <mchan@xxxxxxxxxxxx>]

On Mon, 2005-04-25 at 15:18 -0700, David S. Miller wrote:
> All 3 patches applied, looks great.
> 
> The only thing I see is that we might want to put a
> rmb() at the beginning of tg3_has_work() since we are
> clearing the status block bit right before we call it.
> It might not be necessary though.
> 

I think memory barriers are not needed since tg3_has_work() does not
depend on what's been written or read before it, other than sblk->status
which is a direct dependency.