Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel

["David S. Miller" <davem@xxxxxxxxxxxxx>]

On Wed, 6 Apr 2005 12:21:55 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, Apr 05, 2005 at 10:01:38PM +0200, Patrick McHardy wrote:
> > 
> > Good idea, I didn't think of this. This patch is without replacement of
> > xfrm_init_tempsel(), it caused an "unused function" warning and, as I
> > mentioned before, I still need the function.
> 
> Thanks.  Just one more issue that I can think of, the check should
> only be done when tmpl->id.spi != 0.  Otherwise the presence of
> valid states with differing state selectors will prevent new
> sessions from starting up.

Is it really worthwhile, right now, to change that tmpl->id.daddr to
daddr?  That seems to be all that Patrick's most recent patch does.