netdev
[Top] [All Lists]

Re: [PATCH] skbuff: remove old NET_CALLER macro

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] skbuff: remove old NET_CALLER macro
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Tue, 19 Apr 2005 11:35:00 -0700
Cc: shemminger@xxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <E1DNnit-0001Qz-00@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <20050419174458.0ae804f3@xxxxxxxxxxxxxxxxxxxxx> <E1DNnit-0001Qz-00@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 19 Apr 2005 18:04:43 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> Why not turn this if block into a BUG_ON? The return address will be
> printed by BUG anyway.

Also, __builtin_return_address(0) does not work reliably on some
platforms, notably MIPS.  However, you are making a straight
transformation so you're not making things any worse than before.

Eventually, this belongs in linux/compiler.h as "function_caller()"
or something like that.

<Prev in Thread] Current Thread [Next in Thread>