| To: | Adrian Bunk <bunk@xxxxxxxxx> |
|---|---|
| Subject: | Re: 2.6.12-rc2-mm3: hostap: do not #include .c files |
| From: | Jouni Malinen <jkmaline@xxxxxxxxx> |
| Date: | Mon, 18 Apr 2005 19:12:38 -0700 |
| Cc: | Andrew Morton <akpm@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, hostap@xxxxxxxxx, jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050419020312.GR5489@xxxxxxxxx> |
| Mail-followup-to: | Adrian Bunk <bunk@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, hostap@xxxxxxxxx, jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx |
| References: | <20050411012532.58593bc1.akpm@xxxxxxxx> <20050419020312.GR5489@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.8i |
On Tue, Apr 19, 2005 at 04:03:12AM +0200, Adrian Bunk wrote: > drivers/net/wireless/hostap/hostap.c:#include "hostap_crypt.c" > Please do not #include .c files. A tested patch would be appreciated.. ;-) > A proper separation in a .c file and a header file is the better > solution. Agreed and this is on my to-do list, but not very high on it. Some of these would be relatively easy to fix, but the hardware specific ones (different register offsets for PC Card/PLX/PCI) would require quite a bit of changes to get rid of this. -- Jouni Malinen PGP id EFC895FA |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Fw: [Bug 3998] ARP issues after RC1, Herbert Xu |
|---|---|
| Next by Date: | [2.6 patch] drivers/net/appletalk/: make 2 firmware images static const, Adrian Bunk |
| Previous by Thread: | 2.6.12-rc2-mm3: hostap: do not #include .c files, Adrian Bunk |
| Next by Thread: | [2.6 patch] drivers/net/appletalk/: make 2 firmware images static const, Adrian Bunk |
| Indexes: | [Date] [Thread] [Top] [All Lists] |